Skip to content

feat(remix)!: Drop support for Remix v1 #14988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 17 commits into from
Jan 17, 2025
Merged

feat(remix)!: Drop support for Remix v1 #14988

merged 17 commits into from
Jan 17, 2025

Conversation

chargome
Copy link
Member

@chargome chargome commented Jan 13, 2025 •
edited
Loading

  • Drops support for Remix v1.
  • Drops support for React <18 in Remix (Remix v2 depends on React 18)
  • Removes v1 integration tests
  • Removes v1 e2e tests

ref ##14263

@chargome chargome self-assigned this Jan 13, 2025
@lforst lforst mentioned this pull request Jan 16, 2025
Closed
4 tasks
@chargome chargome marked this pull request as ready for review January 16, 2025 11:08
@codecov Codecov
Copy link

codecov bot commented Jan 16, 2025 •
edited
Loading

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
688 1 687 299
View the full list of 1 ❄️ flaky tests 
tracing/request/fetch/test.ts should create spans for fetch requests

Flake rate in main: 7.69% (Passed 36 times, Failed 3 times)

Stack Traces | 10.1s run time 
test.ts:7:11 should create spans for fetch requests

To view more test analytics, go to the Test Analytics Dashboard
📢 Thoughts on this report? Let us know!

onurtemizkan
onurtemizkan approved these changes Jan 16, 2025
View reviewed changes
Copy link
Collaborator

@onurtemizkan onurtemizkan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me! Added a few minor comments.

@chargome chargome merged commit 56f82aa into develop Jan 17, 2025
148 checks passed
@chargome chargome deleted the cg/drop-remix1-support branch January 17, 2025 12:10
@chargome chargome mentioned this pull request Jan 20, 2025
Merged
chargome added a commit that referenced this pull request Jan 20, 2025
@chargome @mydea
ci: Update labels for remix integration tests (#15076)
62fdfe7 
- Updates the label for remix integration tests.
- Updates client types for captureRemixServerException params 

Follow up to #14988

---------

Co-authored-by: Francesco Gringl-Novy <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@onurtemizkan onurtemizkan onurtemizkan approved these changes

@lforst lforst lforst approved these changes

@AbhiPrasad AbhiPrasad Awaiting requested review from AbhiPrasad

Assignees

@chargome chargome

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chargome @onurtemizkan @lforst